Fix explicit ComputeBasic app freezing on window resize#2090
Open
janetliuAMD wants to merge 1 commit intocinder:vulkanfrom
Open
Fix explicit ComputeBasic app freezing on window resize#2090janetliuAMD wants to merge 1 commit intocinder:vulkanfrom
janetliuAMD wants to merge 1 commit intocinder:vulkanfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The explicit ComputeBasic sample app will hang during window resize/maximize.
This is because the semaphore
mComputeDoneSemaphorewaited on by rendering operation submitted indraw()is never signaled after a resize operation, as explained in pull request #1724 .This fix is part of the changes in the above mentioned pull request which fixes the semaphore bug, without the VkPresentModeKHR enum change for
VK_PRESENT_MODE_MAX_ENUM, as Cinder's current vulkan.h in tools/vulkan usesVK_PRESENT_MODE_MAX_ENUMinstead ofVK_PRESENT_MODE_MAX_ENUM_KHR, which might be the reason #1724 didn't pass.